feat: React re-architecture #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jul 11, 2023
There was a problem hiding this comment.
added number of comments. Will also create a separate PR with some fixes / changes.
About the overall architecture, I have following questions:
- does it make sense that "static" things like "freezeMenu" are part of "state"? (sorry for opening up this discussion again, seems we're going a bit back and forth)
- Plugin views are recreated indeed when other plugins are changed / added. This is by design in prosemirror, probably so that plugins can react to changes to the view that other plugins make. Although it works (see my separate PR that fixes the issues you ran into with this), I think it will be nicer (and faster) to register all plugins on editor instantation
After the comments have been addressed, lets discussed this including your bullets above that haven't been addressed yet
packages/core/src/extensions/DraggableBlocks/DraggableBlocksPlugin.ts
Outdated
Show resolved
Hide resolved
packages/core/src/shared/plugins/suggestion/SuggestionPlugin.ts
Outdated
Show resolved
Hide resolved
packages/react/src/FormattingToolbar/components/FormattingToolbar.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts
Show resolved
Hide resolved
YousefED
reviewed
Jul 31, 2023
YousefED
reviewed
Jul 31, 2023
* fix initialcontent and uniqueid * fix * Removed ready check in `BlockNoteView` --------- Co-authored-by: Matthew Lipski <matthewlipski@gmail.com>
YousefED
reviewed
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of issues with the current rendering implementation in React:
useBlocknote, causing issues.document.bodyinstead of being a sibling to the editor.uiFactoriesoption, which is kind of clunky.This PR is a major rethink of how we create, render, and pass elements to the editor in React (also changes the vanilla implementation a bit).