-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: clean blockcontainer #1137
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
51f4216
extract updateBlockCommand
YousefED 18ff213
Extracted remaining commands
matthewlipski de6f1ec
extract keyboard shortcuts
YousefED c3cea79
move directory
YousefED 717301e
remove createblockcommand
YousefED 9c32c92
Added merge/split tests
matthewlipski 3fe50d5
Updated snapshots
matthewlipski 6a0fda3
Added update block tests and unified test setup
matthewlipski df6dccc
Added test cases for reverting props
matthewlipski d4f206d
Added additional test cases for changing content type
matthewlipski 5ac23d9
remove "nested" insert option
YousefED fc0010b
Split remaining commands & cleaned up
matthewlipski e392637
Added `getNearestBlockContainerPos`
matthewlipski 5dd4afd
Refactored `getBlockInfoFromPos`
matthewlipski 58016a9
Rewrote `splitBlockCommand`
matthewlipski 6bcd81d
Added text cursor position tests
matthewlipski ab18dd4
Fixed lint issue
matthewlipski 968b6fc
fix lint
YousefED 89a86fb
Fixed `splitBlock` selection
matthewlipski adb0907
Merge remote-tracking branch 'origin/refactor/clean-blockcontainer' i…
matthewlipski ba11dd2
Small fix
matthewlipski dd572c3
Added unit tests to check selection setting
matthewlipski 74a0cda
simplify splitblocks
YousefED 690ec6a
Merge branch 'refactor/clean-blockcontainer' of github.com:TypeCellOS…
YousefED f57b0eb
Fixed selection in `splitBlock` tests
matthewlipski 1236476
wip: deprecate getBlockInfoFromPos
YousefED 7b17ded
finish cleanup
YousefED bf4635e
Fixed `mergeBlocks` edge cases
matthewlipski 3f73033
fix build
YousefED 0a50308
Merge branch 'refactor/clean-blockcontainer' of github.com:TypeCellOS…
YousefED 9ae58f6
clean nodeconversions
YousefED 80c8b46
Implemented PR feedback
matthewlipski 1414e14
Finished review and remaining changes
matthewlipski f627732
Fixed bug in `insertOrUpdateBlock`
matthewlipski 3d09350
Removed log
matthewlipski 3d0e80e
Tiny changes
matthewlipski cb1e705
Merge pull request #1151 from TypeCellOS/refactor/clean-blockcontaine…
matthewlipski ab902c9
Fixed merge/delete behaviour on Backspace
matthewlipski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO Y: before merging review all function docs