Added destroy function so vanilla custom blocks can clean ip betwee…

…n renders
TypeCellOS · Aug 31, 2023 · 99f7738 · 99f7738
1 parent 8cbbc50
commit 99f7738
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/core/src/extensions/Blocks/api/block.ts b/packages/core/src/extensions/Blocks/api/block.ts
@@ -1,4 +1,4 @@
-import { Attribute, Node } from "@tiptap/core";
+import { Attribute, Attributes, Node } from "@tiptap/core";
 import { BlockNoteDOMAttributes, BlockNoteEditor } from "../../..";
 import styles from "../nodes/Block.module.css";
 import {
@@ -10,6 +10,7 @@ import {
   TipTapNodeConfig,
 } from "./blockTypes";
 import { mergeCSSClasses } from "../../../shared/utils";
+import { ParseRule } from "prosemirror-model";
 
 export function camelToDataKebab(str: string): string {
   return "data-" + str.replace(/([a-z])([A-Z])/g, "$1-$2").toLowerCase();
@@ -27,7 +28,7 @@ export function propsToAttributes<
     BlockConfig<BType, PSchema, ContainsInlineContent, BSchema>,
     "render"
   >
-) {
+): Attributes {
   const tiptapAttributes: Record<string, Attribute> = {};
 
   Object.entries(blockConfig.propSchema).forEach(([name, spec]) => {
@@ -63,7 +64,7 @@ export function parse<
     BlockConfig<BType, PSchema, ContainsInlineContent, BSchema>,
     "render"
   >
-) {
+): ParseRule[] {
   return [
     {
       tag: "div[data-content-type=" + blockConfig.type + "]",
@@ -228,9 +229,11 @@ export function createBlockSpec<
           ? {
               dom: blockContent,
               contentDOM: rendered.contentDOM,
+              destroy: rendered.destroy,
             }
           : {
               dom: blockContent,
+              destroy: rendered.destroy,
             };
       };
     },

diff --git a/packages/core/src/extensions/Blocks/api/blockTypes.ts b/packages/core/src/extensions/Blocks/api/blockTypes.ts
@@ -115,9 +115,11 @@ export type BlockConfig<
     ? {
         dom: HTMLElement;
         contentDOM: HTMLElement;
+        destroy?: () => void;
       }
     : {
         dom: HTMLElement;
+        destroy?: () => void;
       };
 };