-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit inline values to current function-scope #14
Conversation
@TylerLeonhardt Any way to profile this type of extension? |
This is ready for review.
|
I noticed you had a couple other commits. Ready for me now @fflaten? |
Yes please. Ready for review, but not merge as I'm missing a MIT license if not more depending on comments. Glad I did the last commits while I waited though as it went from 11 to 1 sec test time 😄 |
Friendly reminder for review 🙂 |
Awesome work! Published. It should take a few minutes to show up |
Thanks 👏 If PowerShell/PowerShellEditorServices#1886 gets merged it would be natural to update this to also track/scope to class, configuration or method/constructor in addition to functions. |
I think leaving the setting there for now is totally ok. Let's see if anyone complains about the new behavior and if they do, they have an easy way to revert back. If no one complains, then we can take it out :) |
The extension only shows values for variables in local scope. To reduce noise and wrong values (local values shown for matching variables in parent scopes) this PR filters the lines that are being scanned to only cover relevant parts.
Use function start as startline when stopped inside a function, else document start as before. Always exclude other functions.
Pester.psm1
~17k lines)Fix #8