-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile: Replace ancient gcc
crate with cc
#28
Conversation
gcc
crate with cc
gcc
crate with cc
The `gcc` crate hasn't been updated for 5 years and clearly states that is deprecated after a rename to `cc`. More importantly we're cross-compiling some Windows ISPC code to aarch64 and while GitHub's actions runners definitely have [all the cross- compiling packages installed] the old `gcc` crate was complaining that it could not find `lib.exe` for the desired target. Note that this strangely happened to work fine on a developer machine, but it is unclear why. [all the cross-compiling packages installed]: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#workloads-components-and-extensions
Thanks @MarijnS95 , this looks great to me! The CI runs have been failing because of an issue with ISPC and fneg that I have to look into. Maybe a newer version of ISPC would fix this. |
https://github.com/MarijnS95/ispc-rs/actions/runs/7153113257 1.22 is still broken, fwiw. Only on Mac. |
@Twinklebear oh, because Mac installs via |
If https://formulae.brew.sh/formula/ispc is to be believed, 1.22 should be available. |
https://github.com/MarijnS95/ispc-rs/actions/runs/7153175524/job/19479324178 hmm |
Actually on my mac it seems I have ISPC 1.22 already, and don't remember doing anything specific to install that version. Maybe it's just a matter of waiting til the CI runners update. I'll update the ISPC version for the jobs that download it from Github |
Looks like adding a |
Good find, I only tried that on a run with explicit At least on https://github.com/Traverse-Research/ispc-downsampler/blob/ec3de05b04fe882c8575571ec9ff8fb06b7badf7/.github/workflows/generate-binaries.yaml#L48-L62 we just download ISPC from GitHub releases to match. |
The
gcc
crate hasn't been updated for 5 years and clearly states that is deprecated after a rename tocc
.More importantly we're cross-compiling some Windows ISPC code to aarch64 and while GitHub's actions runners definitely have all the cross-compiling packages installed the old
gcc
crate was complaining that it could not findlib.exe
for the desired target.Note that this strangely happened to work fine on a developer machine, but it is unclear why.