Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node-uuid as default random path generator #52

Closed
Starefossen opened this issue Oct 17, 2015 · 0 comments
Closed

Use node-uuid as default random path generator #52

Starefossen opened this issue Oct 17, 2015 · 0 comments
Assignees
@Starefossen
Labels
breaking change
Milestone
v2.0.0

Comments

@Starefossen
Copy link
Contributor

PR #41, and v1.1.0, introduced the possibility to use a custom random path generator such as node-uuid. The benefit with Universally unique identifiers are that they are guaranteed to be unique and we no longer need the collision check which will speed things up a little 😄

This is a breaking change, so this will have to wait for v2.0.0 before we can do the switch.
@Starefossen Starefossen self-assigned this Oct 17, 2015
@Starefossen Starefossen added this to the v2.0.0 milestone Oct 17, 2015
Starefossen pushed a commit that referenced this issue Nov 10, 2015
feat(path): use node-uuid as default random path generator
e887cc0 
The benefit with Universally unique identifiers, over traditional random path
generators, are that they are guaranteed to be unique. We no longer need to
check for colliding paths before uploading which will speed things up a little.

BREAKING CHANGE: this will change the path structure for new uploaded images.
The old format `aa/bb/cc` will be replaced by `aaaaaa-bbbb-cccc-dddd-eeeeee`.

Closes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Starefossen Starefossen

Labels
breaking change
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@Starefossen