Added option for converting date to string. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Starefossen Is there a chance you might be able to review this PR and let me know if there's anything I should do to make it ready to merge? |
Starefossen
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #67, this creates an option (
date.toString) to use JavaScript date objects in queries rather than ISO strings. I didn't add test coverage for the option against all date formats, as it seemed that demonstrating the option works for each date method is sufficient.Changing the arrow functions to standard functions does make things a bit uglier, but it's necessary to access the options on the bound
this.