Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin AdvancedPS test dep to 0.6.0 #2482

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Pin AdvancedPS test dep to 0.6.0 #2482

merged 1 commit into from
Jan 27, 2025

Conversation

penelopeysm
Copy link
Member

The different RNG in 0.6.1 causes some numerical accuracy tests to fail. Still investigating but I think it makes sense to pin this for now to avoid random failures.

@penelopeysm penelopeysm marked this pull request as ready for review January 27, 2025 19:15
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (ea35bb7) to head (2d593fa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
+ Coverage   82.61%   84.45%   +1.84%     
==========================================
  Files          21       21              
  Lines        1570     1570              
==========================================
+ Hits         1297     1326      +29     
+ Misses        273      244      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12996571154

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 75.831%

Totals Coverage Status
Change from base Build 12931439479: 1.8%
Covered Lines: 1186
Relevant Lines: 1564

💛 - Coveralls

@penelopeysm penelopeysm merged commit eb08db0 into master Jan 27, 2025
59 of 62 checks passed
@penelopeysm penelopeysm deleted the py/advancedps branch January 27, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants