Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v0.6 #330

Closed
ChrisRackauckas opened this issue Aug 9, 2017 · 11 comments
Closed

Upgrade to v0.6 #330

ChrisRackauckas opened this issue Aug 9, 2017 · 11 comments

Comments

@ChrisRackauckas
Copy link
Collaborator

Julia v0.6 is the current release. It seems there's no tests on v0.6, and when I try using Turing on v0.6 it stalls.

@yebai
Copy link
Member

yebai commented Aug 15, 2017

Yes, we plan to work on that. There is an issue preventing us from using Julia 0.6 at the moment, see

#173

JuliaLang/METADATA.jl#10646 (comment)

@yebai
Copy link
Member

yebai commented Aug 28, 2017

I made some progresses on this issue. Now Turing can load within Julia 0.6, however, some tests are currently broken (Pkg.test("Turing")) -- the issue seems related to a change on the Julia side (JuliaLang/julia#21356).

Ps. the code is in #341

@kleinschmidt
Copy link
Contributor

kleinschmidt commented Sep 27, 2017

See also JuliaLang/julia#19774

Also in the docs: https://docs.julialang.org/en/stable/manual/methods/#Redefining-Methods-1

If you (re)define a method f, it can't be called directly in the current runtime, you need to use invokelatest(f, args...). Note that there's a (potential?) performance penalty associated with this, because inference can't happen with invokelatest.

@xukai92
Copy link
Member

xukai92 commented Oct 3, 2017

I found that if we do the model evaluation and calling sample(), Julia doesn't throw the error. E.g.

modelf = gdemo(x)
sample(modelf, alg)

@xukai92
Copy link
Member

xukai92 commented Oct 3, 2017

From https://docs.julialang.org/en/stable/manual/methods/#Redefining-Methods-1

But neither you, nor any of your callers, nor the functions they call, or etc. can call this new method definition!

@emilemathieu
Copy link
Collaborator

Any news on this issue ?
Do we have a list of the issues/tests yet solved ?

@xukai92
Copy link
Member

xukai92 commented Nov 7, 2017

@emilemathieu Please see #341

In short Turing can be used in Julia 0.6 in this PR, and we are adapting the new co-routine and fixing some minor issues.

@yebai
Copy link
Member

yebai commented Nov 8, 2017

@xukai92 let's try to merge the PR this week - I will make an effort of fixing coroutine issue; Could you fix other known issues?

@emilemathieu
Copy link
Collaborator

Duplicate: #293

@yebai
Copy link
Member

yebai commented Nov 12, 2017

As of now, all tests in #341 are passing on Julia 0.6.

@xukai92 Could you fix remaining warnings in the branch?

@ChrisRackauckas
Copy link
Collaborator Author

For the warnings you can just install Femtocleaner

https://github.com/JuliaComputing/FemtoCleaner.jl

yebai added a commit that referenced this issue Nov 16, 2017
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
emilemathieu pushed a commit that referenced this issue Nov 17, 2017
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
yebai added a commit that referenced this issue Sep 18, 2018
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants