-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals #649
Modals #649
Conversation
CUSTOM MODALLLSSS I LOVE THIS!! |
Thanks! The amount of effort to get even normal modals working was insane! |
you need to make the dialogs/modals text only, As you can run JavaScript with them, example in linked video. |
oh fuck, 1 day in and someone already found an exploit in it. |
Lol yeah |
|
I fixed it! I'm a dumbass for using innerHTML and span tbh. I changed it to a paragraph instead. Also, I used textContent as well. |
:D, nice, but you should probally remove the dialog element when it is closed as you make a new one everytime. |
That should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was wondering the same thing loll
there was some git madness from trying to replace my openai extension repo lol. |
Never thought about modals. It looks good to easy pop-up message. But "Green flag" block already exists at "Runtime Options" and "Set var : if/else" block is replaceable to "Couplers" extension. Also the boolean <variable> block, too. |
yeah, I kinda added those in as some extra blocks. |
Related: #674 Some specific examples of the problems described in that issue:
The modals are interesting. If you change this extension to something that just focuses on modals, that should be fine |
Easier said then done |
this request thread basically died, probably going to make a new pr that isn't so Random Utils focused. |
Modals in TurboWarp.
![image](https://private-user-images.githubusercontent.com/81382687/250367108-715faeef-9eb3-4b5b-891e-c3fda5672e7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzc2MzAsIm5iZiI6MTczOTE3NzMzMCwicGF0aCI6Ii84MTM4MjY4Ny8yNTAzNjcxMDgtNzE1ZmFlZWYtOWViMy00YjViLTg5MWUtYzNmZGE1NjcyZTdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA4NDg1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUxMjIwNzhiN2E1OThhMzJjZDVlZjczNzI1OGEzNjg3ZWNhOGE1NGJkYTVjNWQ3ZDUwYTBhY2FlMjIyN2MxODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GVKEmqtDyEvynqsERHZQA73JJahkQHbrl5uo0oix5OI)