-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Effects extension #210
Conversation
Perhaps just "effects" would have been better. Or "shaders" |
It may be worth adding these blocks:
|
finished images (#204) |
@Xeltalliv By the way, maybe add #177 effects in the future? |
In terms of code, it makes more sense to make that a separate extension. I might eventually make it. Or someone else might make it. And for this reason, calling this extension "Effects" may be slightly problematic. |
@Xeltalliv Well, in fact, all these are the effects of displaying sprites. It would not be very convenient to divide them into "Color effects" and "Something effects" Perhaps "Render" is good alternative |
@Xeltalliv I edited the code a bit:
Here is it |
I don't think that's a better name. I think I'll keep it named "Effects". (Also, there's no need to mention me. I made this PR, so I'm automatically subscribed to all activity in it. I'm also Watching this repository, so I actually get notified about everything) |
Ok I changed name back and once again modified code |
Do you agree with changes? |
Yes
Keeping class named just
There is a reason why it was called that way.
It was formatted in the way I prefer. Double/more empty lines are used to more visibly separate distinct sections of code. Trailing commas in "blocks" and "menus" were also intentional. |
Maybe rename this extension to Clipping if you are not planning on adding other effects. |
Okay) I asked and offered everything I wanted. You made excellent extension! Good luck in the future) |
Note to GarboMuffin: this extension modifies gl state, but doesn't fully restore it at the end. Despite that it seems to work. I'm not sure if it's better to keep it as is, or make it intercept, save and then restore everything which will add extra overhead, but potentially improve compatibility. |
This seems like another case where a documentation page could be beneficial I'll fix the merge conflicts and merge this in a bit, such a documentation page can be added later if you want to |
ok |
because Effects is too generic and this is unlikely to get new features.
Example of using those blocks:
Adds 2 effects:
Those effects are cleared after stopping the project. They affect stamps, but don't affect pen. Touching blocks work as if those effects don't exist. They are disabled for stage.