Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some block labels #1860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DNin01
Copy link
Collaborator

@DNin01 DNin01 commented Jan 9, 2025

Old New
without waiting and continue
broadcast message to sprite send message to sprite

- without waiting -> and continue
- broadcast to sprite -> send to sprite
@DNin01 DNin01 requested a review from GarboMuffin January 9, 2025 22:48
@DNin01 DNin01 added the pr: change existing extension Pull requests that change an existing extension label Jan 9, 2025
@GarboMuffin
Copy link
Member

im not opposed to it

@CubesterYT
Copy link
Member

This is great, the previous wording was bad

@SharkPool-SP
Copy link
Collaborator

I am opposed to the changes in More Events. The blocks are supposed to be based on this:
image

@DNin01
Copy link
Collaborator Author

DNin01 commented Jan 10, 2025

I am opposed to the changes in More Events. The blocks are supposed to be based on this

I only changed "broadcast" to "send" on the sprite-specific message-sending blocks. The blocks that broadcast messages to all sprites still say "broadcast".

Blocks to broadcast messages or send messages to sprites

@DNin01 DNin01 removed the request for review from GarboMuffin January 10, 2025 20:56
@GarboMuffin
Copy link
Member

"broadcast" in the parallel programing sense means "send to everyone" which those blocks don't do. MPI separates these operations into MPI_Bcast and MPI_Send

@GarboMuffin
Copy link
Member

GarboMuffin commented Jan 10, 2025

Though it still is a broadcast in that sense since it goes to all the clones of that sprite too

@CubesterYT
Copy link
Member

I mean, if there is clones, you can think of it as a Carbon Copy type of send

Where it is still sending, but there are extra recipients getting the same information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants