-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommended
config
#71
Conversation
Are you going to have time to take a look? |
you are doing a lot of different changes in this PR which makes it significantly harder to review. can you split them up into dedicated PRs where each PR only changes one specific thing? 🙏 |
2a8803d
to
a711e9a
Compare
I've removed the ES6 changes which were the bulk of the PR. The number of changes in this PR are much smaller now; they are just a handful of small changes instead. Is that ok? I can submit the refactoring PR separately which has more changes, though of the same type. |
you still have a list of things that it does in the description. adjusting the CI config is a separate thing, doing stuff with |
a711e9a
to
9886b30
Compare
Ok, I've changed to just handle one item in this PR. I can submit the others separately. Please review this one if you would. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some documentation on how to enable this config in ESLint?
c70d8a7
to
9b00c0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
…ll current rules
9b00c0b
to
43e8d47
Compare
plugins
and all current rules (one as a warning); fixes Add recommended config #69- Linting: Rename eslintrc to include recommended extension- git/npm: Add package-lock.json to ignored files- npm: Add recommended package.json fields (contributors, dependencies)- npm: AddpeerDependencies
as called for by ESLint- Travis: Add Node 12/ESLint 6 and Node 10/ESLint 5 testsYour Travis file tests ESLint 2 and your README insists on a minimum version of 4, so I wasn't sure which one to fix (and thus which to use in thepeerDependencies
field which ESLint calls for).As far as Node version, FWIW, your devDeps
import-from
andeslint
can both be updated to the latest versions if you move to a minimum version of Node 8.