-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint flat config support #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR seems to contain a bunch of unrelated changes that should probably go into dedicated PRs
The point is that eslint v9 is a breaking change: the configuration system switched from 'legacy' to 'flat'. As a consequence, you cannot simply run the unit-tests with As a consequence, we have to change the tests in the ci workflow that use different versions of eslint. For that I created the "tests for all supported eslint versions". As another consequence, we cannot simply use Probably we could use this version of the plugin even with So it's your decision: what commits should I move to another pr. I will gladly change anything you want. |
Before I forget it; one more comment: I didn't find a script that sets the |
So now I moved the changes that are not related to the addition of the flat configuration to new pr (#380 and #381). As eslint v8 and v9 using a flat configuration file require different configs than the older versions, I had to split up the ci workflow tests with all major eslint versions into 2 different sequences. I hope the current structure conforms better with your ideas 😄, |
Add ESLint flat config support - breaking change
So now this pr is ready to be merged. BTW: thank you for making me a collaborator - it's an honor for me. |
19db1e7
to
3dffed8
Compare
I've found a way to use the existing test suite even with ESLint 9 (see #388), which means we don't have to duplicate all of the test files, making the code base much more maintainable. I've thus removed all of the additional test setup in this PR, leaving only the config changes. Since the only breaking change in this PR is the rename of the |
Added support for eslint 'legacy' and 'flat' configuration files.
Therecommended
configuration is used for the new flat configuration. The recommended configuration for the legacy system is renamed torecommended-legacy
(as recommended by the eslint documentation).(see #378 (comment))