-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage #100
Conversation
I've rebased and also bumped the version to drop Node 6 (the latest nyc I added requires it, it also would allow using up-to-date versions of Mocha and |
This comment has been minimized.
This comment has been minimized.
Thanks for the merge! I've rebased this one now as well... |
Was breakage with Mocha 8 and ESLint 3, so also dropped <=3 from peerDeps and Travis. |
And with Mocha 8 requiring Node 10 and Node 8 end-of-lifed, I added another commit to drop Node 8 from |
@brettz9 can you split these changes into multiple PRs so that they can be discussed individually? 🙏 |
23109fb
to
da21335
Compare
Sure, I'm happy to split them up, and I started #114 which presents one item by itself. FWIW though, if you are interested to know my process on why I connected all of these... I added Since the latest |
84253d2
to
16d26cb
Compare
Rebased also with no breaking changes. |
This PR adds a few more tests to improve the test coverage of the plugin to 100%