Detect missing assertions in an arrow body (#248)

Turbo87 · Aug 4, 2022 · 8c036c8 · 8c036c8
1 parent 214f366
commit 8c036c8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/rules/missing-assertion.js b/lib/rules/missing-assertion.js
@@ -29,7 +29,15 @@ module.exports = {
 
         let {callee} = expression;
         checkCallee(callee, node);
-      }
+      },
+      ArrowFunctionExpression(node) {
+        if (
+          node.body && node.body.type === 'CallExpression' &&
+          node.body.callee
+        ) {
+          checkCallee(node.body.callee, node.body);
+        }
+      },
     };
   }
 };
diff --git a/tests/lib/rules/missing-assertions.js b/tests/lib/rules/missing-assertions.js
@@ -29,7 +29,10 @@ ruleTester.run('missing-assertion', rule, {
         return expect(true).to.be.ok();
       });
     `
-  }],
+  }, {
+    code: 'it("works as expected", () => expect(true).to.be.true);',
+    parserOptions: { ecmaVersion: 6 },
+  } ],
 
   invalid: [{
     code: `
@@ -49,5 +52,11 @@ ruleTester.run('missing-assertion', rule, {
     errors: [{
       message: 'expect(...) used without assertion'
     }]
+  }, {
+    code: 'it("fails as expected", () => expect(true));',
+    parserOptions: { ecmaVersion: 6 },
+    errors: [{
+      message: 'expect(...) used without assertion'
+    }]
   }]
 });