Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary Shellcheck disabled issues #60

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gitrise.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env bash

# shellcheck disable=SC2155
# disbales "Declare and assign separately to avoid masking return values."
# shellcheck disable=SC2120
Expand Down
2 changes: 2 additions & 0 deletions tests/build_artifacts_tests.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/usr/bin/env bash

#shellcheck disable=SC1091

source ./gitrise.sh -T

testFetchingBuildArtifactsSlugs() {
Expand Down
6 changes: 1 addition & 5 deletions tests/build_info_tests.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155,SC2154,SC2034
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.
# var is referenced but not assigned.
# var appears unused
# shellcheck disable=SC1091,SC2155

source ./gitrise.sh -T

Expand Down
5 changes: 1 addition & 4 deletions tests/build_logs_tests.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155,SC2154
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.
# var is referenced but not assigned.
# shellcheck disable=SC1091,SC2155

source ./gitrise.sh -T

Expand Down
3 changes: 1 addition & 2 deletions tests/build_status_message_tests.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.

source ./gitrise.sh -T

testBuildTimedOutMessage() {
Expand Down
6 changes: 1 addition & 5 deletions tests/download_single_artifacts_tests.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155,SC2154,SC2034
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.
# var is referenced but not assigned.
# var appears unused
# shellcheck disable=SC1091,SC2155

source ./gitrise.sh -T

Expand Down
3 changes: 1 addition & 2 deletions tests/gitrise_logs_tests.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155,SC2154
# Not following: (error message here)
# shellcheck disable=SC1091,SC2155

source ./gitrise.sh -T -d

Expand Down
2 changes: 0 additions & 2 deletions tests/input_validation_tests.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.

testMissingWorkflow() {
local expected_message="ERROR: Missing arguments(s). All these args must be passed: --workflow,--slug,--access-token"
Expand Down
3 changes: 1 addition & 2 deletions tests/options_tests.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#!/usr/bin/env bash

# shellcheck disable=SC1091,SC2155
# Not following: (error message here)
# Declare and assign separately to avoid masking return values.

source ./gitrise.sh -T

testEnvVars() {
Expand Down