Return non-zero if any errors occur #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonvom
force-pushed
the
fail-build-on-any-errors
branch
2 times, most recently
from
57e5440 to
3f74ce5
Compare
|
Hi @andersonvom thank you for your contribution! I'm considering merging this PR, but the develop branch has been updated. Can you please update your branch? |
Builds currently succeed whenever using the `--download-artifacts` flag, because `exit_code` is overridden with the return value of `curl`. This initiates `exit_code=0` and ensures that any errors will be accumulated to it as the build progresses. If any errors occur, either during the build or the downloading of artifacts, `exit_code` will have a non-zero value, which will ensure the script exits with an error code.
andersonvom
force-pushed
the
fail-build-on-any-errors
branch
from
3f74ce5 to
a3e5d34
Compare
|
Hey @Azbagheri! This was a busy week, but I've just rebased the MR! Please let me know there's anything else needed. |
Azbagheri
approved these changes
Nov 22, 2024
|
Hey @andersonvom thank you for rebasing the PR. Going to merge it soon. This change will be available in the next release of gitrise which will go out this weekend. Thanks again for addressing the bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds currently succeed whenever using the
--download-artifactsflag, becauseexit_codeis overridden with the return value ofcurl.This initiates
exit_code=0and ensures that any errors will be accumulated to it as the build progresses. If any errors occur, either during the build or the downloading of artifacts,exit_codewill have a non-zero value, which will ensure the script exits with an error code.