Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for Rubocop and Allow export by modified FIleSet #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkorcy
Copy link
Contributor

@mkorcy mkorcy commented Jan 6, 2025

Tisch/Tarc want smaller export sets so they want to see export by file sets that have changed rather than metadata, this adds that capability, and I've run it against items this year.

Copy link
Contributor

@rawOrlando rawOrlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. one question, one small change. Also, a note that there is no need to do it now, but i think it would be nice if we made tests for new functionality


# mkdir for object
process_file_sets(obj, steward, collection, obj_dir, include_metadata)
write_metadata(obj, steward, collection, obj_dir) if include_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write_metadata_file(file_set, metadata_file) if include_metadata is called in process file set. this line saves the collections metadata. Is is not redundant, right?

def validate_file_length(file_path)
if file_path.length > 254
random_string = SecureRandom.alphanumeric(10)
@logger.error "File path too long: #{file_path.length} characters. Mapping to random string."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should log the random string incase there is any confusion about which file it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants