Theme checks grouping improvements #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gargol looks awesome, I think there are just two minor refinements:
|
naz
added a commit
that referenced
this pull request
Apr 16, 2019
refs #210 - Tweaks based on this feedback - #217 (comment)
|
@peterzimon the tweak above landed in master with a680d78 . They were not too related to this changeset, so pushed them right away 👍 |
peterzimon
approved these changes
Apr 16, 2019
|
These will need an additional review of how new 'fatal' group is used in Ghost-Admin and gscan web client. Will be done once other priorities are cleared. |
|
To be revived once this issue becomes a priority again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #215