-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backbone begins #90
Backbone begins #90
Conversation
After (if) this is merged I'll get onto the other views, one by one, so that parallel work isn't disrupted. |
"use strict"; | ||
|
||
Ghost.Collection.Posts = Backbone.Collection.extend({ | ||
url: Ghost.settings.baseURL + '/posts' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@jgable good point on |
I'm not getting any errors from |
You should be able to login and see the errors from travis, by first logging in at magnum-ci.travis.com. Travis is timing out. Probably doesn't mean anything. You should be able to restart builds that look like they shouldn't have failed? |
I tried out squashing the commits of a pull request, which means this has my name next to it and didn't auto-close the PR. Not sure if that was a good or bad idea, just want to start getting a much cleaner history. |
I had already squashed this as two commits (add dependencies, then implement) for easy reversal. GH probably only auto-closes the PR if the commit hashes match. Looks good anyway, working on the settings page now. edit: you can ask the author to do the squashing to preserve authorship, then rebase & merge |
and thanks for the travis tip, now I can finally see why the build fails 🤘
|
I think the two commits might make more sense for having clean history here, since one only had the lib additions and the other the relevant code. |
This builds on @tgriesser's work on #87, but restricting changes to the blog view. It's a huge patch even so, but I think it merges cleanly, and keeps all existing features in a working state.
I tried to be conservative about the implementation, so not everything is done _the true backbone way_™ until other pieces fall into place (routing, collections & state management, etc).