[WIP] closes #5093 - Changing page parameter concept for offset in API operations #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing the page parameter in API operations - Adding the offset parameter in API operations - Fixing the tests for the new concept
|
This PR is looking great so far, only minor nitpick is to please update the commit message to have a description line like this: https://github.com/TryGhost/Ghost/wiki/Git-workflow#commit-messages as that's what goes in the changelog. |
edsadr
changed the title
|
@edsadr sorry for leading you down the garden path with this one. We're not going to pursue this change for the reasons explained in #5093 (comment). |
|
not a problem will check next week other issues to engage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing page parameter concept for offset in post API operations