frontend functional tests -> frontend route tests #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - Some of the tests were duplicated and all of these tests are faster and easier to do with super test as we aren't testing interactions - Introduced a new test util to toggle permalinks which allows us to test the different structures - Using cheerio in route tests to test the HTML / XML output is well formed
|
WARNING: Do NOT merge - Travis is actually failing with a disk space error |
|
This now has a legitimate test pass. |
jaswilli
added a commit
that referenced
this pull request
Oct 25, 2014
frontend functional tests -> frontend route tests
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all of the tests from
/functional/frontend/*into/functional/routes/frontend_test.js- there weren't many, and several of them already had equivalent tests in the route tests.There's no need for us to test the frontend of a blog using casper/phantom as we don't need to test interactions.
This should give us a small reduction in the time taken to run our build 🚤
no issue