Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow schema changes #2931

Merged
merged 1 commit into from
Jun 13, 2014
Merged

Allow schema changes #2931

merged 1 commit into from
Jun 13, 2014

Conversation

sebgie
Copy link
Contributor

@sebgie sebgie commented Jun 10, 2014

closes #2354
refs #1641

@tgriesser
Copy link
Contributor

I'm scratching my head wondering how this actually works without bumping bookshelf. There were huge internal changes between knex 0.5 and knex 0.6 which Bookshelf 0.6 relied on for anything related to relations.

Also, there was a huge regression around memoizing column names in 0.6 -> 0.6.9 that was causing the test-suite to fail for me when starting from a fresh ghost repo (fixed in 0.6.10, but I'm not sure why they weren't showing up...)

@tgriesser
Copy link
Contributor

Oh, nevermind, I know why, it's because bookshelf was installing it's own copy of knex locally to match the dependency version in bookshelf, and because you're not currently requiring it, initializing and passing into bookshelf (which will be required going forward), the version bump in this PR doesn't actually do anything with regards to knex.

closes TryGhost#2354
refs TryGhost#1641

- added addUnique()
- added dropUnique()
- added addColumn() -> needed for TryGhost#2330
- dropColumn() is missing due to lack of knex support
- further cleanup of the migrations module
@sebgie
Copy link
Contributor Author

sebgie commented Jun 12, 2014

Updated :-)

ErisDS added a commit that referenced this pull request Jun 13, 2014
@ErisDS ErisDS merged commit 8eb602f into TryGhost:master Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User schema changes
3 participants