-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional objects #2652
Additional objects #2652
Conversation
@@ -398,11 +399,13 @@ Post = ghostBookshelf.Model.extend({ | |||
pagination.prev = pagination.page - 1; | |||
} | |||
} | |||
|
|||
// console.log(tagInstance); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
I think it'd be good to get the filter returned object consistent and create it as an array from the start. We do know that it will be the case that we'll support multiple filters as querying for a certain tag with a given author is something that we'll want. If it was more hazy about what this filter param would support then I'd agree we should wait, but this is something that we know is coming down the pipeline. |
@hswolff I didn't want to anticipate any future implementation. I could update the object as follows:
It will then use the first element of the first tags object for now and if multiple resources are needed we can update it accordingly? |
👍 |
I'm imagining an API that would request
Then again I don't want to go down the road of premature optimization too much so take all I say with that grain. I just do imagine this is a future we will have. |
That was the point where I decided to write:
Without any code in place I think that your option using |
I am hoping for that future to be a reality very, very soon 😸 |
I think @hswolff's structure makes sense? |
Aha, I mis-read then, my mistake, apologies. Carry on then. :B |
👍 |
1 similar comment
👍 |
closes TryGhost#2620 - moved aspect -> filters - updated tests - fixed inconsistency in pagination object
Updated! I think the build needs a restart as it worked on my repo (https://travis-ci.org/sebgie/Ghost/builds/23877352). |
closes #2620
filters: {tags:[{id: 1, ...}]}