Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 Limited permissions for uploaded files to 0644 #21841

Merged
merged 7 commits into from
Dec 10, 2024
Merged

🔒 Limited permissions for uploaded files to 0644 #21841

merged 7 commits into from
Dec 10, 2024

Conversation

vershwal
Copy link
Member

@vershwal vershwal commented Dec 9, 2024 •
edited
Loading

Fixes https://linear.app/ghost/issue/ENG-1010/uploaded-file-permission-security-improvement

  • This commit ensures all files uploaded to Ghost via importer are set with 0644 permissions to improve security.
  • Uploaded files previously retained their original permissions, which could leave them executable.
  • This commit prevents files from being inadvertently executable.

@vershwal vershwal changed the title Set file permissions 🔒 Limited permissions for uploaded files to 0644 Dec 10, 2024
@vershwal vershwal merged commit 9476afb into main Dec 10, 2024
43 checks passed
@vershwal vershwal deleted the setFilePermissions branch December 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
browser-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vershwal