Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce post settings events #1632

Merged
merged 1 commit into from
Dec 11, 2013
Merged

Debounce post settings events #1632

merged 1 commit into from
Dec 11, 2013

Conversation

hswolff
Copy link
Contributor

@hswolff hswolff commented Dec 7, 2013

This fixes #1582.

I wrapped the relevant event handlers in _.debounce with a buffer of 0.5 to prevent over-eager updates.

I also changed the toggleStaticPage function to use the actual checkbox property because otherwise after the function is run it would only inverse the current setting. So clicking the checkbox 3 times (back to the initial state) would end up just toggling it to the opposite.

Let me know what needs modifying, I didn't fully understand the issue but this is my first shot at fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Settings: Delay & debounce onBlur save event
2 participants