Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at #81 #105

Merged
merged 1 commit into from
Jun 1, 2013
Merged

Another attempt at #81 #105

merged 1 commit into from
Jun 1, 2013

Conversation

tgriesser
Copy link
Contributor

This'll make doing #101 and other data model related items much easier.

@tgriesser tgriesser mentioned this pull request Jun 1, 2013
6 tasks
@tgriesser
Copy link
Contributor Author

Also, it creates a separate ghost namespace'd database instance, so it doesn't conflict if other people happen to be using Bookshelf/Knex alongside their app.

It also moves filterCallbacks and filters off the prototype, because you almost never want to specify arrays or objects directly on the prototype unless you're sure you're never going to modify them from new instances (which we aren't in this case because it's a singleton, but that's beside the point)...

Because javascript is pass-by-reference for object values, you generally don't want objects/arrays on the prototype, always in the constructor.

ErisDS added a commit that referenced this pull request Jun 1, 2013
@ErisDS ErisDS merged commit d4f43c2 into TryGhost:master Jun 1, 2013
morficus pushed a commit to morficus/Ghost that referenced this pull request Sep 4, 2014
daniellockyer pushed a commit that referenced this pull request Jul 20, 2022
no issue

- As members have become a part of Ghost core there is no need to proxy methods like this anymore and we can allow members-api to work on the model directly
- Methods come from Ghost core: https://github.com/TryGhost/Ghost/blob/cc39786/core/server/services/members/api.js#L11-L110
daniellockyer pushed a commit that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants