-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a configuration option for whether we add or remove trailing slashes from the URLs #1028
Conversation
I can't speak to the intention of requiring them in the first place, but two points on your PR:
|
Also, please could you follow https://github.com/TryGhost/Ghost/wiki/Git-workflow#notes-on-writing-good-commit-messages. |
I'll review and re-submit. Closing pending that. |
This seems like over configuration and is not something we'd be open to without a clear use case that serves the majority of users. Seems like plugin territory to me. |
I am not sure if this happens for everyone but the facebook scraper seems to have an issue with a trailing slash. you could try this here with-slash and without-slash . Should individual posts be considered like directories by default? A helper option would be nice |
@ajeeshpu If you think you have found a bug please raise it as a proper bug according to the contributing guidelines using the bug report template. As it stands I don't have anywhere near enough information other than to say 'Works for me'. |
@ErisDS apologies. Will do that |
I couldn't find a bug report for this so I opened one at #4828 |
refs TryGhost#2459 This includes updating handlebars to v4 as well as other fixes which will introduce breaking changes to the theme API: From express-hbs: - partials must now use the `.hbs` extension, the same as templates From handlebars: - Depthed paths are now conditionally pushed on to the stack. If the helper uses the same context, then a new stack is not created. This leads to behavior that better matches expectations for helpers like if that do not seem to alter the context. Any instances of ../ in templates will need to be checked for the correct behavior under 4.0.0. In general templates will either reduce the number of ../ instances or leave them as is. See TryGhost#1028. - The = character is now HTML escaped. This closes a potential exploit case when using unquoted attributes, i.e. <div foo={{bar}}>. In general it's recommended that attributes always be quoted when their values are generated from a mustache to avoid any potential exploit surfaces.
refs TryGhost#2459 This includes updating handlebars to v4 as well as other fixes which will introduce breaking changes to the theme API: From express-hbs: - partials must now use the `.hbs` extension, the same as templates From handlebars: - Depthed paths are now conditionally pushed on to the stack. If the helper uses the same context, then a new stack is not created. This leads to behavior that better matches expectations for helpers like if that do not seem to alter the context. Any instances of ../ in templates will need to be checked for the correct behavior under 4.0.0. In general templates will either reduce the number of ../ instances or leave them as is. See TryGhost#1028. - The = character is now HTML escaped. This closes a potential exploit case when using unquoted attributes, i.e. <div foo={{bar}}>. In general it's recommended that attributes always be quoted when their values are generated from a mustache to avoid any potential exploit surfaces.
No description provided.