Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that mocha tests always run successfully #91

Closed
ErisDS opened this issue May 29, 2013 · 3 comments
Closed

Ensure that mocha tests always run successfully #91

ErisDS opened this issue May 29, 2013 · 3 comments
Labels
bug [triage] something behaving unexpectedly
Milestone
0.2

Comments

@ErisDS
Copy link
Member

ErisDS commented May 29, 2013

At the moment, Travis sometimes fails to run the mocha tests, it seems because the tests run in parallel and interfere with one another.

This needs to be fixed so that we can rely on Travis to validate pull requests
@jgable
Copy link
Contributor

jgable commented May 29, 2013

I've noticed this as well. The DataProvider constructor is also attempting to do the migrations.down().up() dance, so maybe refactoring that to have an init() function would help.

That's my best guess at the moment. Sucks because we can only really test after the fact by seeing how Travis reacts.

jgable added a commit to jgable/Ghost that referenced this issue May 29, 2013
@jgable
Fix Travis Errors
d81d408 
- affects TryGhost#91
- Move dataProvider initialization outside constructor
- Add travis sqlite config that enables debug
- Add grunt-cli installation to travis before_script
@jgable jgable mentioned this issue May 29, 2013
Merged
@ErisDS
Copy link
Member Author

ErisDS commented May 29, 2013

Given that the build passed on the merge request with this change, there's a pretty strong chance this has fixed it :)

@jgable
Copy link
Contributor

jgable commented Jun 9, 2013

I think we can close this now, seems to be passing pretty consistently.

@ErisDS ErisDS closed this as completed Jun 9, 2013
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
@jgable
Fix Travis Errors
f0ce5c4 
- affects TryGhost#91
- Move dataProvider initialization outside constructor
- Add travis sqlite config that enables debug
- Add grunt-cli installation to travis before_script
This was referenced Sep 12, 2021
Open
Open
@fooiskandar fooiskandar mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@ErisDS @jgable