Zelda Audit

[JohnONolan]

Followup of #5314

ALL TESTED IN SAFARI 8.0.7 for OSX - I am actively working on these issues

• Broken publish menu position image
• Dropdown shadow too heavy image
• "Team" is lowercase and author name is cut off, on author profiles image
• Button alignment and button text alignment are wrong on author cover image upload modal image
• Loading buttons are not centered
• No indication that saving settings has succeeded
• "View blog" contrast too low
• Full name should align with fields below image
• Button text alignment on invite user is wrong image
• Invitation confirmation should be a notification rather than an alert image
• There is no indication of any kind when you "resend" and invitation
• Unstyled validation on settings/general image
• Subsequent error loop of death image / console
• Further saves of settings/general do nothing
• Contrast on tag description too low image
• Settings menu image upload-by-URL button alignment is wrong image
• Meta data submenu missing right-chevron on tag-settings-menu image
• Tried to save user after changing role from author=>editor, infinite loading button, nothing happened
• For some reason clicking anywhere in the content highlights the entire thing image
• validation causing forms to load with green icons (should be grey) image
• Signin form should not be validating inline if field is empty image
• Not enough space for validation on signin form image
• Editor frequently ends up in a state where the loading button is permanently spinning for no reason when you open it. Seems to happen when a loading spinner has stalled out or messed up on a previous screen. image
• "Edit icon" on content management screen should not have an :active / depressed state
• Hit area on the ? icon is WAY too small
• Can't actually sign in at all on Chrome - licecap - terminal - console (when I then manually refreshed, I was already signed in)
• AutoNav flickering - safari / chrome
• The width of the publish button is being set with JS (why?!) which is breaking whenever the content changes image
• Publish button height has regressed image
• CMD+Backspace does not work to delete a post in safari (content mgmt screen)
• Tag input has unintentional box shadow image
• The download count on setup is incorrectly formatted (needs comma) image
• Do not validate empty form fields on setup image
• Pressing "tab" after the last input field takes keyboard focus to address bar. Should be: submit button. image
• User invite validation should be properly coloured image
• Validation message does not disappear even though I have fixed it image
• Can we inject that validation message into the button instead of under the textarea?
• "Failed to send 1 invitationS ? Come on now. Aside from bad grammar, this also needs to be more helpful and offer a suggestion as to why this might be the case. image
• Duplicate alerts should not stack image
• When I click back to step 2, my password field is empty and validation is red. Now I don't know if I need to enter this again, or not? Has this step already been completed? Do I have to do it again? Genuinely confused, and I know how this works, roughly! image
• Hang on, what instructions? Why do I need instructions? image
• Clicked on "forgot password" and then nothing happened, at all, except the button disabled itself. What am I supposed to do now? (Also, clearly it couldn't send the email, I haven't got any mail svc configured) image -- oh, after like 10 mins this appeared image

By Hannah

• gravatar behaviour doesn't fire until blur moved to Revisit gravatar aspect of image component on setup/signup #5797
• skip to content link doesn't work detailed comment
• need to hide search bar
• using tab navigation on tag page TSM causes meta menu to half-open image - reproduce by putting cursor in name field and tabbing until you see this.
• session expiry issues
• loading interstitial & pre-app loading screen moving to post-zelda
• double click to open post not working on content screen
• No validation on user invites

Loading buttons: Don't know how to solve

When an action takes more than 1s, the loading spinner makes sense in a button. But when an action takes 0.1s - adding/removing a loading spinner makes the button feel broken. I think we need a mandatory "success" animation which can follow the loading animation when the route is not changing. I don't think this is going to be easy.

Also: When logging in, the loading button stops spinning before the admin loads. This should not happen. It should keep spinning all the way until the route changes without ever stopping

Mobile

All tested on latest Chrome for iOS

• Small viewport: title cut off image
• Mobile menu should close on route change
• "Collapse sidebar" icon should also close mobile menu
• Mobile menu hit area too small
• Horizontal scroll/overflow when mobile menu is open
• Can't edit any post (when you tap on post in content mgmt, nothing happens)
• Need a way to trigger mobile uploads

[acburdine]

@JohnONolan the reason the width of the publish button is being set with JS is because when the spinner is activated on post save, the width of the button will shrink to the size of the spinner. This can be removed; however, I didn't have any other good ideas on what to do to prevent the button from shrinking when the spinner is active.

[JohnONolan]

@acburdine The way we handle this on Ghost.org is that when a loading-button is clicked:

1. The width of the button is retrieved with jQuery
2. The width of the button is set to itself with jQuery
3. The text of the button is replaced with the span of the loading element with jQuery

(so width is only fixed when it needs to be, not all the time)

[acburdine]

@JohnONolan ah gotcha. That's kind of the way I was doing it, but not exactly, so I'll PR a fix to it.

[kevinansfield]

Can't actually sign in at all on Chrome

I've just seen the same issue in Safari too

[ErisDS]

Items are all checked off!