Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CasperJS tests for mobile interactions and views #403

Closed
14 tasks
matthojo opened this issue Aug 16, 2013 · 3 comments
Closed
14 tasks

CasperJS tests for mobile interactions and views #403

matthojo opened this issue Aug 16, 2013 · 3 comments

Comments

@matthojo
Copy link
Contributor

I think we should add some CasperJS tests to make sure mobile versions of Ghost are working correctly. I'll update this issue with possible tests to include.

Designs: #149

 Header / Sidebar

  • Sidebar is hidden and not visible
  • Header button slides in sidebar on tap
  • Links in sidebar are correctly titled

 Dashboard

  • Widgets are correct sizes and do not break layout (currently broken)

Content

  • Preview is hidden
  • Default view is post links
  • Tapping on post links slide in previews

 New Post

  • Default panel is 'Markdown'
  • Preview panel is hidden
  • There is a 'Preview' panel header
  • 'Preview' panel header when tapped displays the preview

Settings

  • Settings options are hidden
  • Default view is settings sections links
  • Tapping on settings section slides in right settings options page
@ghost ghost assigned matthojo Aug 18, 2013
@matthojo
Copy link
Contributor Author

matthojo commented Sep 9, 2013

Current progress on these tests can be found at https://github.com/matthojo/Ghost/tree/Interaction-Tests. / @ErisDS

@ErisDS
Copy link
Member

ErisDS commented Sep 11, 2013

Punting this to 0.4.

@ErisDS ErisDS added tests and removed architecture labels Feb 26, 2014
@ErisDS ErisDS modified the milestones: Localisation, Multi-user, Future Apr 15, 2014
@ErisDS ErisDS mentioned this issue Jun 17, 2014
Closed
61 tasks
@JohnONolan
Copy link
Member

Most of the spec'd tests here have already changed (no longer relevant) and the rest probably will change. Suggest revisiting this in a new issue as we start to implement proper mobile support with Ember

@ErisDS ErisDS removed this from the Future Release Backlog milestone Aug 20, 2014
@ErisDS ErisDS closed this as completed Aug 20, 2014
daniellockyer pushed a commit that referenced this issue Jul 20, 2022
@allouis
Fixed checkout session creation for existing members (#403)
8e2c600 
refs TryGhost/Product#1526

We weren't using the `req.body.customerEmail` to load a member and
check their existing tiers, this meant that existing members which
were signed out and attempted to create a stripe checkout session were
able to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @JohnONolan @matthojo