Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No <Users button for authors #3295

Closed
ErisDS opened this issue Jul 16, 2014 · 8 comments
Closed

No <Users button for authors #3295

ErisDS opened this issue Jul 16, 2014 · 8 comments
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.

Comments

@ErisDS
Copy link
Member

ErisDS commented Jul 16, 2014

Split from #3086


If the currently logged in user is an author, and they are viewing their profile, then the <Users button which usually appears:

user button

Should not be there:

no button

Note: this is client interface specific, and is not based on permissions. We have canThis permissions on the server side which effect the API and the user's ability to make data changes. There is no client-side permission system at present, for now an if-statement based on role will suffice.

@ErisDS ErisDS added this to the 0.5 Multi-user milestone Jul 16, 2014
@novaugust
Copy link
Contributor

I'll take this as a similar feature's in #3084

@novaugust
Copy link
Contributor

Ah, nevermind, I'd love to have a beginner take it instead =)

@jetrois
Copy link

jetrois commented Jul 20, 2014

What exactly needs to be done?

@novaugust
Copy link
Contributor

@jetrois: essentially, that button that sends someone up a level from /users/me to just /users shouldn't be there if the user doesn't have permission to view the users page. But, that can't be done until #3325 gets fixed, sadly :(

@jetrois
Copy link

jetrois commented Jul 20, 2014

I see. thanks for explaining!

@novaugust
Copy link
Contributor

Sure thing. I'd be happy to ping you when we get 3225 in if you'd like
On Jul 20, 2014 10:33 AM, "Jetrois Mathurin" notifications@github.com
wrote:

I see. thanks for explaining!


Reply to this email directly or view it on GitHub
#3295 (comment).

@jetrois
Copy link

jetrois commented Jul 20, 2014

cool.

@ErisDS
Copy link
Member Author

ErisDS commented Jul 22, 2014

@jetrois #3325 is in so this should be possible now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Projects
None yet
Development

No branches or pull requests

3 participants