Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember.js] Fixtures: Add enough fake posts to allow for them to require infinite scroll in the view #2415

Closed
hswolff opened this issue Mar 16, 2014 · 4 comments · Fixed by #2782
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Milestone

Comments

@hswolff
Copy link
Contributor

hswolff commented Mar 16, 2014

This is needed for #2414.

We need to flesh out enough posts so that we can then mock out the UI for the infinite list view.

Find the current fixture here: https://github.com/TryGhost/Ghost/blob/ember/core/client/fixtures/posts.js

@ErisDS ErisDS added the client label Mar 18, 2014
@ErisDS ErisDS added this to the Ember.js milestone Mar 18, 2014
@ErisDS
Copy link
Member

ErisDS commented Mar 18, 2014

Requires #2347

@hswolff
Copy link
Contributor Author

hswolff commented Mar 20, 2014

I may pick this up to just get it in.

FWIW this tool will make this task insanely easy.

http://www.json-generator.com/

I'd also love for you to commit the template you use to generate the content as well, so if we modify the JSON structure it'll be easy to update the dummy data as well.

@morficus
Copy link
Contributor

Taking a shot at this, here is the same generated data: https://gist.github.com/morficus/64cef3bbd5066b24a431

Here are some items that I am kind of unsure if they are represented correctly:

  • in posts author, created_by, updated_by and published_by are user object
  • dates are all in ISO 8601 format
  • in tags created_by and updated_by are just integers (I wasn't able to find anything indicating that they should be objects)

Let me know if there is anything that needs to be changed.
I'll issue a proper PR once I get an informal acknowledgment.

@ErisDS
Copy link
Member

ErisDS commented May 17, 2014

@morficus That all sounds correct. A PR for this would be awesome 👍

morficus added a commit to morficus/Ghost that referenced this issue May 20, 2014
closes TryGhost#2415
- data now match the new Posts API data structure
- has enough entries to allow for scrolling
- also including the generator template (as a txt file) used in json-generator.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants