Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Excerpt/Content helper don't work as expected #1591

Closed
halfdan opened this issue Nov 29, 2013 · 4 comments · Fixed by #1594
Closed

[Bug] Excerpt/Content helper don't work as expected #1591

halfdan opened this issue Nov 29, 2013 · 4 comments · Fixed by #1594

Comments

@halfdan
Copy link
Contributor

halfdan commented Nov 29, 2013

See: https://ghost.org/forum/bugs-suggestions/3169-excerpt-characters-not-outputting-properly/
halfdan added a commit to halfdan/Ghost that referenced this issue Nov 29, 2013
@halfdan
Remove quotes from excerpt helper documentation.
fa750e8 
fixes TryGhost#1591
@halfdan halfdan mentioned this issue Nov 29, 2013
Closed
@ErisDS
Copy link
Member

ErisDS commented Nov 29, 2013

In my opinion this is a bug in the helper, not in the docs. All attribute value pairs in our helpers should use quotes, the same as HTML - there should be no ambiguity as to whether you need quotes or not.

The helper / downsize should correctly handle the attribute value and assume it is a number, not a string.

@JohnONolan
Copy link
Member

All attribute value pairs in our helpers should use quotes, the same as HTML

Very yes

@halfdan
Copy link
Contributor Author

halfdan commented Nov 29, 2013

Fair enough. The helper examples in the code were without quotes, that's why I assumed the docs were wrong. Gonna update my PR then.

@halfdan halfdan mentioned this issue Nov 29, 2013
Merged
halfdan added a commit to halfdan/Ghost that referenced this issue Nov 29, 2013
@halfdan
Fix excerpt/content helpers
5c1091a 
fixes TryGhost#1591
- Convert quoted strings to numbers
- Update code examples
- Update helper tests
@ErisDS
Copy link
Member

ErisDS commented Nov 30, 2013

Ooh good catch on the in-code docs 👍

digitaljhelms added a commit to digitaljhelms/ghostium that referenced this issue Nov 30, 2013
@digitaljhelms
Correcting excerpt characters
56f324c 
Issue reported at TryGhost/Ghost#1591 and fixed at TryGhost/Ghost@d69e87b
digitaljhelms added a commit to digitaljhelms/ghostium that referenced this issue Dec 10, 2013
@digitaljhelms
Correct excerpt characters
fe6ad44 
Issue reported at TryGhost/Ghost#1591 and fixed at TryGhost/Ghost@d69e87b
digitaljhelms added a commit to digitaljhelms/ghostium that referenced this issue Dec 10, 2013
@digitaljhelms
Correct excerpt characters
03449f1 
Issue reported at TryGhost/Ghost#1591 and fixed at TryGhost/Ghost@d69e87b
@digitaljhelms digitaljhelms mentioned this issue Dec 10, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix excerpt/content helpers halfdan/Ghost
3 participants
@ErisDS @JohnONolan @halfdan