Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App.js Naming #154

Closed
JohnONolan opened this issue Jun 14, 2013 · 4 comments
Closed

App.js Naming #154

JohnONolan opened this issue Jun 14, 2013 · 4 comments
Assignees
@ErisDS
Milestone
0.2

Comments

@JohnONolan
Copy link
Member

It's a pedantic naming thing - but app.js bugs the fuck out of me. It just sounds way too generic / weird. I would like to propose start.js.
@ghost ghost assigned ErisDS Jun 14, 2013
@ErisDS
Copy link
Member

ErisDS commented Jun 15, 2013

app.js is the main application file, so to me it makes sense. In other programming languages it might be called main.js because it contains the main function. I think often in node it is index.js, or server.js

To start Ghost, you can type npm start instead of node app.js

@JohnONolan
Copy link
Member Author

👍 for index.js

@ErisDS
Copy link
Member

ErisDS commented Jun 25, 2013

Note: this will also have to change deploy scripts, Vagrant instructions etc

@JohnONolan
Copy link
Member Author

Totally - that's why I wanted to get it stabilised sooner rather than later!

ErisDS added a commit that referenced this issue Jul 7, 2013
@ErisDS
Config and naming
3d2b56b 
- issue #154, issue #224 and issue #220
- change port number from 3333 to 2368
- change main file name from app.js to index.js
- update README & package.json to match
@ErisDS ErisDS closed this as completed Jul 7, 2013
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
@ErisDS
Config and naming
fed5055 
- issue TryGhost#154, issue TryGhost#224 and issue TryGhost#220
- change port number from 3333 to 2368
- change main file name from app.js to index.js
- update README & package.json to match
This was referenced Sep 12, 2021
Open
Open
Open
Open
@amgir amgir mentioned this issue May 13, 2022
Open
@mdno mdno mentioned this issue May 14, 2022
Open
daniellockyer pushed a commit that referenced this issue Jul 20, 2022
@rishabhgrg
Added plan update option to stripe subscription update API (#154)
b015a08 
no issue

- Current update stripe subscription API calls only allowed cancelling a plan
- This change adds option to pass plan's nickname as `planName` in request to update subscription to new plan
- Checks if plan name is valid and updates stripe subscription to new plan at default prorate behavior
@amgir amgir mentioned this issue Sep 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErisDS ErisDS

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@ErisDS @JohnONolan