Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Members] Direct portal links to checkout plans #12365

Closed
9 tasks done
rishabhgrg opened this issue Nov 16, 2020 · 1 comment
Closed
9 tasks done

[Members] Direct portal links to checkout plans #12365

rishabhgrg opened this issue Nov 16, 2020 · 1 comment
Assignees
@rishabhgrg

Comments

@rishabhgrg
Copy link
Contributor

rishabhgrg commented Nov 16, 2020 •
edited
Loading

Currently this can only be done using data- attributes, which means the links only work from inside the publication and not from, for example, an email.

MVP Solution

  • A new portal signup link for monthly plan
  • A new portal signup link for yearly plan

Improvements

  • A new portal signup link for "free" plan, which opens signup popup, with plans hidden
  • Better error handling, open default portal for any unknown, or unhandled action.

Tasks

  • UI for MVP
  • Portal handling for MVP
    • browser back button from Stripe checkout takes users to infinite navigation loop
  • UI for improvement link
    • Clicking on any of these links we shouldn’t display the portal popup but navigate directly to Stripe checkout
  • Portal handling for improvement link
    • Link (signup/free) that opens the portal popup but hides all plans
  • Error handling
  • Stripe back button takes users to home. should take them to whereever they came from
@rishabhgrg rishabhgrg self-assigned this Nov 16, 2020
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 17, 2020
@rishabhgrg
Added direct links for monthly/yearly checkout
784ba9f 
refs TryGhost/Ghost#12365

Currently, while its possible to open Stripe checkout directly on a monthly/yearly plan, Portal links don't allow similar feature. This change allows opening a site on a specific Portal link that can directly open Stripe checkout for monthly/yearly plan, if the plan is allowed.

- Adds handling for new portal signup link for monthly plan - `/#/portal/signup?plan=monthly`
- Adds handling for new portal signup link for yearly plan - `/#/portal/signup?plan=yearly`
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Nov 17, 2020
@rishabhgrg
Added portal direct links for plan checkout
913617e 
refs TryGhost/Ghost#12365

Portal now allows direct checkout links for monthly/yearly plans via Portal links or data attributes, allowing members to directly signup to a paid plan. This PR adds -

- A new portal signup link for monthly plan - `/signup/monthly`
- A new portal signup link for yearly plan - `/signup/yearly`
@rishabhgrg rishabhgrg mentioned this issue Nov 17, 2020
Merged
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 17, 2020
@rishabhgrg
Updated portal direct checkout links to use path
dc1c34a 
refs TryGhost/Ghost#12365

Last commit added Portal checkout links using query param on signup link - `signup?plan=monthly/yearly`, this updates the checkout links to use path instead of params on links and data attributes instead.

Portal link for monthly plan checkout - `#/portal/signup/monthly`
Portal data attribute for monthly plan checkout - `data-portal=signup/monthly`

Portal link for yearly plan checkout - `#/portal/signup/yearly`
Portal data attribute for monthly plan checkout - `data-portal=signup/yearly`
rishabhgrg added a commit to TryGhost/Admin that referenced this issue Nov 17, 2020
@rishabhgrg @peterzimon
✨ Added new portal links for plan checkout (#1770)
d361a22 
refs TryGhost/Ghost#12365

Portal now allows direct checkout links for monthly/yearly plans via Portal links or data attributes, allowing members to directly signup to a paid plan. This PR adds -

- A new portal signup link for monthly plan - `/signup/monthly`
- A new portal signup link for yearly plan - `/signup/yearly`

Co-authored-by: Peter Zimon <zimo@ghost.org>
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 19, 2020
@rishabhgrg
Updated direct plan checkout without popup
806bdd4 
refs TryGhost/Ghost#12365

- Updated direct checkout to load Stripe without opening popup
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 19, 2020
@rishabhgrg
Cleared portal checkout link on use
f7e3a20 
refs TryGhost/Ghost#12365

- Browser back button from Stripe checkout takes users to infinite navigation loop as we were not clearing the direct checkout link
- Clears direct checkout link on load so user can continue navigation as normal
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 19, 2020
@rishabhgrg
Added direct portal link for free signup
14d7e88 
refs TryGhost/Ghost#12365

- Added direct portal link handling for - `/signup/free` - to open Portal with Free plan only when available
- In case free plan is not available, Portal will show default signup screen
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 20, 2020
@rishabhgrg
Added listener for portal link changes
e82e208 
refs TryGhost/Ghost#12365

- Listens to portal link changes in URL and opens direct checkout plans
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Nov 20, 2020
@rishabhgrg
Added new portal link for free plan
d5e8752 
refs TryGhost/Ghost#12365

Portal allows direct free signup link or data attributes, allowing members to directly share or link to only free plan in Portal popup if available

- A new portal signup link for free plan - `/signup/free`
@rishabhgrg rishabhgrg mentioned this issue Nov 20, 2020
Merged
rishabhgrg added a commit to TryGhost/Admin that referenced this issue Nov 20, 2020
@rishabhgrg
Added new portal link for free plan
aa38883 
refs TryGhost/Ghost#12365

Portal allows direct free signup link or data attributes, allowing members to directly share or link to only free plan in Portal popup if available

- A new portal signup link for free plan - `/signup/free`
rishabhgrg added a commit to TryGhost/Portal that referenced this issue Nov 23, 2020
@rishabhgrg
Updated stripe cancel redirect to existing page
7b76d7a 
refs TryGhost/Ghost#12365

Stripe back button previously redirected user to site home instead of keeping existing link where the checkout was triggered from. This updates the link to go back to old site URL in case the previous URL was still on the Ghost site.
@rishabhgrg
Copy link
Contributor Author

Finished with TryGhost/Portal@7b76d7a

daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Added direct links for monthly/yearly checkout
bbea4f7 
refs #12365

Currently, while its possible to open Stripe checkout directly on a monthly/yearly plan, Portal links don't allow similar feature. This change allows opening a site on a specific Portal link that can directly open Stripe checkout for monthly/yearly plan, if the plan is allowed.

- Adds handling for new portal signup link for monthly plan - `/#/portal/signup?plan=monthly`
- Adds handling for new portal signup link for yearly plan - `/#/portal/signup?plan=yearly`
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Updated portal direct checkout links to use path
d26fad1 
refs #12365

Last commit added Portal checkout links using query param on signup link - `signup?plan=monthly/yearly`, this updates the checkout links to use path instead of params on links and data attributes instead.

Portal link for monthly plan checkout - `#/portal/signup/monthly`
Portal data attribute for monthly plan checkout - `data-portal=signup/monthly`

Portal link for yearly plan checkout - `#/portal/signup/yearly`
Portal data attribute for monthly plan checkout - `data-portal=signup/yearly`
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Updated direct plan checkout without popup
2a091ac 
refs #12365

- Updated direct checkout to load Stripe without opening popup
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Cleared portal checkout link on use
de3e5f5 
refs #12365

- Browser back button from Stripe checkout takes users to infinite navigation loop as we were not clearing the direct checkout link
- Clears direct checkout link on load so user can continue navigation as normal
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Added direct portal link for free signup
9dac6d9 
refs #12365

- Added direct portal link handling for - `/signup/free` - to open Portal with Free plan only when available
- In case free plan is not available, Portal will show default signup screen
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Added listener for portal link changes
8483ba1 
refs #12365

- Listens to portal link changes in URL and opens direct checkout plans
daniellockyer pushed a commit that referenced this issue Oct 5, 2022
@rishabhgrg
Updated stripe cancel redirect to existing page
cfa44b2 
refs #12365

Stripe back button previously redirected user to site home instead of keeping existing link where the checkout was triggered from. This updates the link to go back to old site URL in case the previous URL was still on the Ghost site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhgrg rishabhgrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rishabhgrg