Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented gothic 2 controls #219

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

fhanrath
Copy link
Contributor

Merge for #214

I noticed that the running attack seems to have a bug (even without this change).
In the gothic 1 control scheme the running attack sometimes doesn't work properly. Especially if you already did a normal attack.
In the gothic 2 control scheme the running attack always doesn't work properly.

When you try to initiate the running attack, the hero stops and does a normal attack which seems to hit twice.

I tried to find the issue in npc.cpp doAttack, but couldn't find anything related to the differentiation between a running and a normal attack.

Maybe it would be best to fix this problem in this branch, but I'm a bit lost right now.

The other attacks seem to work like vanilla gothic 2 with gothic 2 controls.

refactor of switching to spells (no more iteration)
@fhanrath
Copy link
Contributor Author

I added a commit to fix the running attack for the g2 controls.
Now the hero doesn't strike twice when doing a running attack. But sometimes he still stops when doing the attack.

In the g1 controls the hero always stops and hits twice now (on my branch and on master).

@fhanrath fhanrath marked this pull request as ready for review November 23, 2021 16:44
@Try Try merged commit 4e72f1e into Try:master Nov 23, 2021
@Try
Copy link
Owner

Try commented Nov 23, 2021

@fhanrath thanks for PR, merged!

@fhanrath fhanrath deleted the feature/opengothic-214 branch November 23, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants