implemented gothic 2 controls #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor of switching to spells (no more iteration)
|
I had a git misconfiguration and opened a new merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge for #214
I noticed that the running attack seems to have a bug (even without this change).
In the gothic 1 control scheme the running attack sometimes doesn't work properly. Especially if you already did a normal attack.
In the gothic 2 control scheme the running attack always doesn't work properly.
When you try to initiate the running attack, the hero stops and does a normal attack which seems to hit twice.
I tried to find the issue in
npc.cpp doAttack, but couldn't find anything related to the differentiation between a running and a normal attack.Maybe it would be best to fix this problem in this branch, but I'm a bit lost right now.
The other attacks seem to work like vanilla gothic 2 with gothic 2 controls.