Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #135

Merged
merged 3 commits into from
Apr 15, 2021
Merged

UI improvements #135

merged 3 commits into from
Apr 15, 2021

Conversation

kuzy000
Copy link
Contributor

@kuzy000 kuzy000 commented Apr 14, 2021

  • Dialogues
    • RMB to skip phrase
    • Esc down (instead of up) to skip phrase
    • Skip fade out animation when phrase is skipped
  • Inventory
    • RMB to close
    • Esc down (instead of up) to close inventory (or trade)
    • Move selection left when there is no space to move up
    • Move selection right when there is no space to move down
    • Maintain selection when switching pages
    • Show selection even if inventory is empty

I checked all the changes in the original game.

kuzy000 added 3 commits April 14, 2021 23:25
* Dialogue
  * RMB to skip phrase
  * Esc down (instead of up) to skip phrase
  * Skip fade out animation when phrase is skipped
* Inventory
  * RMB to close
  * Esc down (instead of up) to close inventory
  * Move selection left when there is no space to move up
  * Move selection right when there is no space to move down
  * Maintain selection when switching pages
@Try Try merged commit 9d53f9c into Try:master Apr 15, 2021
@Try
Copy link
Owner

Try commented Apr 15, 2021

Hi, @kuzy000 !

Thanks for PR, I've tested it - everything works quite nicely!
Special thanks for very 'clean' pull-request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants