Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugging Face Notebook Improvements #2338

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

GiulioZizzo
Copy link
Collaborator

Description

We received user feedback on the Hugging Face notebook, which we have incorporated. Principally, it involves:

  • Additional text in the markdown cells
  • Options to train smaller models on reduced datasets for resource constrained (e.g. cpu only) machines.
  • Displaying progress bars while training.

This feature branches off the current open PR #2334

Fixes # no current issue is associated.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Current ART CI testing suite.

Test Configuration:

  • OS: Mac OS
  • Python version: 3.8
  • ART version or commit number: ART 1.16
  • TensorFlow / Keras / PyTorch / MXNet version: TensorFlow 2.10, pytorch: 1.13

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes have been tested using both CPU and GPU devices

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a281f62) 76.18% compared to head (11a4dc9) 84.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.17.0    #2338      +/-   ##
==============================================
+ Coverage       76.18%   84.08%   +7.89%     
==============================================
  Files             327      327              
  Lines           30850    30856       +6     
  Branches         5716     5716              
==============================================
+ Hits            23503    25945    +2442     
+ Misses           5914     3450    -2464     
- Partials         1433     1461      +28     
Files Coverage Δ
art/estimators/classification/pytorch.py 86.51% <100.00%> (+0.09%) ⬆️
art/estimators/classification/tensorflow.py 82.82% <100.00%> (+13.72%) ⬆️

... and 60 files with indirect coverage changes

@beat-buesser beat-buesser self-requested a review November 30, 2023 15:33
@beat-buesser beat-buesser added this to the ART 1.17.0 milestone Nov 30, 2023
@beat-buesser beat-buesser added enhancement New feature or request improvement Improve implementation and removed enhancement New feature or request labels Nov 30, 2023
@beat-buesser beat-buesser self-assigned this Nov 30, 2023
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
@beat-buesser beat-buesser merged commit 25f7ac0 into Trusted-AI:dev_1.17.0 Dec 22, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants