-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update channels_first
parameter and docstring for PyTorch Object Detectors
#2265
Update channels_first
parameter and docstring for PyTorch Object Detectors
#2265
Conversation
Signed-off-by: Farhan Ahmed <Farhan.Ahmed@ibm.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## dev_1.15.2 #2265 +/- ##
==============================================
+ Coverage 81.63% 85.61% +3.98%
==============================================
Files 308 308
Lines 27476 27476
Branches 5048 5048
==============================================
+ Hits 22429 23523 +1094
+ Misses 3817 2671 -1146
- Partials 1230 1282 +52
... and 30 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
model: Optional["torchvision.models.detection.fasterrcnn_resnet50_fpn"] = None, | ||
input_shape: Tuple[int, ...] = (-1, -1, -1), | ||
model: Optional["torchvision.models.detection.FasterRCNN"] = None, | ||
input_shape: Tuple[int, ...] = (3, 416, 416), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the Faster R-CNN model of torchvision expect this input size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @f4str Thank you very much for the pull request! I have one question about the input shape, what do you think?
Signed-off-by: Farhan Ahmed <Farhan.Ahmed@ibm.com>
11b5511
to
98016c6
Compare
Hi @beat-buesser thank you for the review. As per our discussion, it does make sense to leave the |
Description
Set the
channels_first
parameter inPyTorchObjectDetector
andPyTorchFasterRCNN
to default to true instead of false and update theinput_shape
default parameter accordingly.Additionally, update docstrings and the type hinting for
PyTorchFasterRCNN
.Fixes #2264
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
PyTorchObjectDetector
are unchangedPyTorchFasterRCNN
are unchangedPyTorchYolo
are unchangedTest Configuration:
Checklist