Optional tempeh, conditional imports #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DanielRyszkaIBM <daniel.ryszka@pl.ibm.com>
Signed-off-by: DanielRyszkaIBM <daniel.ryszka@pl.ibm.com>
Signed-off-by: DanielRyszkaIBM <daniel.ryszka@pl.ibm.com>
Signed-off-by: DanielRyszkaIBM <daniel.ryszka@pl.ibm.com>
…d-imports # Conflicts: # aif360/sklearn/datasets/__init__.py # setup.py
hoffmansc
reviewed
Aug 26, 2022
There was a problem hiding this comment.
Thanks, this looks very good overall! Eventually we should remove the tempeh dependency altogether and directly download the dataset from SEAPHE but this is totally fine for now.
I left a couple comments in the code. Also, can you add the import warnings for the aif360.sklearn.preprocessing algos (FairAdapt and LFR)?
Signed-off-by: DanielRyszkaIBM <daniel.ryszka@pl.ibm.com>
hoffmansc
approved these changes
Aug 26, 2022
Illia-Kryvoviaz
pushed a commit
to Illia-Kryvoviaz/AIF360
that referenced
this pull request
Jun 7, 2023
* Make tempeh optional + remove scipy upper bound * Raise warnings if importing uninstalled packages * Change import for deprecation class from sklearn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are introduced:
deprecationclass