Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix standard dataset: adultdataset NotimplementError #115

Merged
merged 4 commits into from
Nov 18, 2019
Merged

fix standard dataset: adultdataset NotimplementError #115

merged 4 commits into from
Nov 18, 2019

Conversation

autoih
Copy link
Contributor

@autoih autoih commented Oct 7, 2019

This PR fixes #109 issue.

@autoih
Copy link
Contributor Author

autoih commented Oct 23, 2019 •
edited
Loading

Hi @hoffmansc, can you help review this PR? Thanks!

@hoffmansc
Copy link
Collaborator

I think it would be simpler to just add .to_numpy() in these places. We would just have to bump up the requirement for pandas to >=0.24.0.

@autoih
Copy link
Contributor Author

autoih commented Nov 15, 2019

Thanks, @hoffmansc. Updated.

hoffmansc
hoffmansc requested changes Nov 15, 2019
View reviewed changes
aif360/datasets/standard_dataset.py Outdated Show resolved Hide resolved
aif360/datasets/standard_dataset.py Outdated Show resolved Hide resolved
hoffmansc
hoffmansc reviewed Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. One other thing: could you change the version requirement in setup.py and requirements.txt to pandas>=0.24.0? to_numpy() was introduced then so that way we don't break anything. Thank you so much!

@autoih
Copy link
Contributor Author

autoih commented Nov 18, 2019

Thanks @hoffmansc. Updated.

@autoih autoih requested a review from hoffmansc November 18, 2019 15:34
hoffmansc
hoffmansc approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for sticking with this one.

@hoffmansc hoffmansc merged commit c718f1d into Trusted-AI:master Nov 18, 2019
@hoffmansc hoffmansc mentioned this pull request May 5, 2020
Merged
@kzenstratus kzenstratus mentioned this pull request Nov 29, 2020
Open
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@autoih @hoffmansc
Fix StandardDataset Pandas FutureWarning (Trusted-AI#115)
f601ca0 
also bumps pandas requirement to >=0.24.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmansc hoffmansc hoffmansc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix deprecation warning in standard dataset
2 participants
@autoih @hoffmansc