Add some more options to the flake8 action

[peternewman]

This also includes #8 .

[peternewman]

Hi @TrueBrain ,

Is this good to merge please? This does enough for me to run this against my codebase and I'd rather use the "official" one if possible.

[TrueBrain]

I am so sorry; for some reason I did not get a notification about this! Happy you gave a poke :) And tnx for this PR, this is awesome :D

One request: would you mind adding a few test cases for this?

So in https://github.com/TrueBrain/actions-flake8/blob/master/example/example.py, make a line of like 90 and 110 chars, set the max length to 100 in https://github.com/TrueBrain/actions-flake8/blob/master/.github/workflows/testing.yml. That should trigger only one. And make an error/warning you put on ignore, so we can see that doesn't happen.

Makes reviewing PRs easier, as that means I can spot if the output is as expected :D

[TrueBrain]

Owh, and pretty please document these two options in the README.md, so other also know about it :) That would be awesome!

[peternewman]

Owh, and pretty please document these two options in the README.md, so other also know about it :) That would be awesome!

🤦 Done. Could do with a way to auto-generate documentation from action.yml files.

[peternewman]

I am so sorry; for some reason I did not get a notification about this! Happy you gave a poke :) And tnx for this PR, this is awesome :D

Don't worry, I wasn't sure if you were busy given the current situation.

One request: would you mind adding a few test cases for this?

So in https://github.com/TrueBrain/actions-flake8/blob/master/example/example.py, make a line of like 90 and 110 chars, set the max length to 100 in https://github.com/TrueBrain/actions-flake8/blob/master/.github/workflows/testing.yml. That should trigger only one. And make an error/warning you put on ignore, so we can see that doesn't happen.

Makes reviewing PRs easier, as that means I can spot if the output is as expected :D

I can go one better and nick the good work of @per1234 in codespell-project/actions-codespell#7 and give you some proper tests and CI if you'd like. Or can it wait for another PR?

Here's a live example with those options turned on FWIW:
https://github.com/peternewman/ola/actions/runs/123856886

[TrueBrain]

Having a proper CI would be awesome, but indeed something for another PR :)

Btw, often it is better to add a .flake8 file in the repo to set ignores and line length, but I don't mind adding this at all :) more options is better :D

[peternewman]

Btw, often it is better to add a .flake8 file in the repo to set ignores and line length, but I don't mind adding this at all :) more options is better :D

Thanks, that's good to know and might be easier keeping our Travis CI and GitHub action run config in sync, I guess it depends how much we want to clutter the repo with config files