Skip to content

Commit

Permalink
test: remove postmortem test from flaky list
Browse files Browse the repository at this point in the history
test-postmortem-metadata does not ever seem to fail on master. According
to Michaël Zasso, when it fails locally for him during a V8 upgrade, he
pings Colin Ihrig who fixes it almost immediately.

There was some discussion about marking it flaky when it first landed
but it's not clear to me that it is necessary. (We can always mark it
flaky again if it turns out that it is necessary.)

The reason I want this test removed from the status file for flaky tests
is that I believe that file can and should be used as a list of tests to
fix. But this test doesn't need any fixing.

Refs: nodejs#17685
  • Loading branch information
Trott committed Jun 2, 2018
1 parent f86e5fc commit 7296973
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# Postmortem debugging data is prone to accidental removal during V8 updates.
test-postmortem-metadata: PASS,FLAKY

[$system==win32]
test-child-process-fork-net: PASS,FLAKY
Expand Down

0 comments on commit 7296973

Please sign in to comment.