Skip to content

Commit

Permalink
build: unbreak --with-intl=system-icu build
Browse files Browse the repository at this point in the history
Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: nodejs#28052
PR-URL: nodejs#28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
bnoordhuis authored and Trott committed Jun 14, 2019
1 parent 30f285d commit 3cdd5a2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -393,13 +393,6 @@
'<(icu_gyp_path):icui18n',
'<(icu_gyp_path):icuuc',
],
'direct_dependent_settings': {
'include_dirs': [
'<(icu_path)/source/common',
'<(icu_path)/source/i18n',
'<(icu_path)/source/tools/toolutil',
],
},
}],
],
}, # v8_maybe_icu
Expand Down

0 comments on commit 3cdd5a2

Please sign in to comment.