Separate FRI parameters from FRI snippet #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To call from, we need to have a snippet object that doesn't require us to set run-time parameters at compile-time which the previous FRI snippet struct did. With this change, setting those parameters at compile-time is optional and only required when invoking tests.
|
Also: Now that we're looking at the interface of the FRI snippet, I think it should not return the |
Co-authored-by: sword-smith <thor@neptune.cash>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To call the FRI snippet outside of an internal testing context, we need to have a snippet object that doesn't require us to set FRI's run-time parameters at compile-time. With this change, setting those parameters at compile-time is optional and only required when invoking tests.
All tests pass.
There might be a cleaner way to achieve this. This was just the 1st thing that I came to mind and that I could get to compile.