-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream tvm pr 295 #103
Merged
Merged
Upstream tvm pr 295 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c_size` Reduces the previous bottle-neck, op-stack table row count, by a factor of 30. From ~900 to 30 for a used by the STARK verifier. Great stuff!
…ynamic length The heavy absorbtion happens over sequences of known lengths (arrays), so this change only gives a minor performance boost. Still a reduction of more than ~1500 clock cycles in the verification of a proof with a tiny inner padded height.
This improves the op-stack table height significantly but actually adds a row to the processor table. So whether or not this is an improvement is arguable.
Cf. upstream changes in Triton-VM this halves the number of combination codeword checks that are performed by the FRI verifier. This saves a great deal of rows (around 25 %) for the verifier. Cf. TritonVM/triton-vm#295
Profile for VM-verifier, inner-padded height
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on upstream TritonVM/triton-vm#295 being merged