Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker run doesn't work with tini #91

Open
jemershaw opened this issue Sep 7, 2016 · 4 comments
Open

Docker run doesn't work with tini #91

jemershaw opened this issue Sep 7, 2016 · 4 comments

Comments

@jemershaw
Copy link

Jenkins uses tini to start the jenkins container, this doesn't seem to work using triton/docker.

@tyoh
Copy link

tyoh commented Sep 8, 2016

I hit the same thing!

@Smithx10
Copy link

Smithx10 commented Sep 8, 2016

"What JEmershaw Meant to say is",

While running:
docker run -d -t -p 8080:8080 -p 50000:50000 --name jenkins-test-2 jenkins:alpine

The Container fails to start because of the following:
docker logs jenkins-test-2
[FATAL tini (92079)] /tcsetpgrp failed: 'No such device or address'

@joshwilsdon
Copy link
Contributor

I ran into this a while ago too and filed https://smartos.org/bugview/OS-5615 internally. I've linked the two tickets now.

krallin added a commit to krallin/docker-1 that referenced this issue Dec 5, 2016
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with
https://github.com/joyent/sdc-docker (see:
TritonDataCenter/sdc-docker#91). The fix itself was
provided by @geek of Joyent.

I've also made the Tini architecture more explicit (since Tini now also
supports ARM), so in case you decide to support additional architectures
in the future, the fix should be more obvious.

There isn't much functional difference between 0.9.0 (which you were
using) and 0.13.1, but here are a few notable changes you might care
about to some extent:

- Tini now supports a `-l` flag to show its license. This was useful
  from a compliance perspective for some users (so considering you're
  shipping Tini that might indirectly be useful to you!).
- Tini now supports a `--version` argument to show its version. This is
  here mostly because it's a little more intuitive than what was there
  before (you'd have to use `-h` to see the version).
- Tini now supports a `TINI_VERBOSITY` environment variable (should be
  an int), which can be convenient for debugging when Tini is used as an
  `ENTRYPOINT` (avoids the need to alter the entrypoint to configure
  it).
- Tini now uses more specific exit codes when it fails to fork (e.g.
  because the binary you're looking for doesn't exist, etc.).
krallin added a commit to krallin/docker-1 that referenced this issue Dec 5, 2016
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with
https://github.com/joyent/sdc-docker (see:
TritonDataCenter/sdc-docker#91). The fix itself was
provided by @geek of Joyent.

I've also made the Tini architecture more explicit (since Tini now also
supports ARM), so in case you decide to support additional architectures
in the future, the fix should be more obvious.

There isn't much functional difference between 0.9.0 (which you were
using) and 0.13.1, but here are a few notable changes you might care
about to some extent:

- Tini now supports a `-l` flag to show its license. This was useful
  from a compliance perspective for some users (so considering you're
  shipping Tini that might indirectly be useful to you!).
- Tini now supports a `--version` argument to show its version. This is
  here mostly because it's a little more intuitive than what was there
  before (you'd have to use `-h` to see the version).
- Tini now supports a `TINI_VERBOSITY` environment variable (should be
  an int), which can be convenient for debugging when Tini is used as an
  `ENTRYPOINT` (avoids the need to alter the entrypoint to configure
  it).
- Tini now uses more specific exit codes when it fails to fork (e.g.
  because the binary you're looking for doesn't exist, etc.).

Thanks for using Tini in this image!
@geek
Copy link

geek commented Dec 6, 2016

PR for official jenkins image to upgrade their tini version: jenkinsci/docker#394

I verified this works... here is a working image: https://hub.docker.com/r/d0cker/jenkins/

fatihkilic pushed a commit to fatihkilic/docker that referenced this issue Apr 14, 2017
This upgrades Tini to 0.13.1 in order to fix a compatibility issue with
https://github.com/joyent/sdc-docker (see:
TritonDataCenter/sdc-docker#91). The fix itself was
provided by @geek of Joyent.

I've also made the Tini architecture more explicit (since Tini now also
supports ARM), so in case you decide to support additional architectures
in the future, the fix should be more obvious.

There isn't much functional difference between 0.9.0 (which you were
using) and 0.13.1, but here are a few notable changes you might care
about to some extent:

- Tini now supports a `-l` flag to show its license. This was useful
  from a compliance perspective for some users (so considering you're
  shipping Tini that might indirectly be useful to you!).
- Tini now supports a `--version` argument to show its version. This is
  here mostly because it's a little more intuitive than what was there
  before (you'd have to use `-h` to see the version).
- Tini now supports a `TINI_VERBOSITY` environment variable (should be
  an int), which can be convenient for debugging when Tini is used as an
  `ENTRYPOINT` (avoids the need to alter the entrypoint to configure
  it).
- Tini now uses more specific exit codes when it fails to fork (e.g.
  because the binary you're looking for doesn't exist, etc.).

Thanks for using Tini in this image!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants